Fixes #482: async mgr "reuseable -> reusable" #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As per CONTRIBUTING, I ran: Initially I received a timeout error, but a subsequent attempt passed, so I'm guessing it's unrelated. I wasn't sure if marking the existing function name as deprecated was necessary/appropriate. I found a comment here on the subject wrt Clojure: But, I figured I'd start with this PR as is, and see what folks thought. |
| @@ -181,7 +181,8 @@ | |||
| (let [regular (conn-mgr/make-regular-conn-manager {}) | |||
| regular-reusable (conn-mgr/make-reusable-conn-manager {}) | |||
| async (conn-mgr/make-regular-async-conn-manager {}) | |||
| async-reusable (conn-mgr/make-reuseable-async-conn-manager {})] | |||
| async-reusable (conn-mgr/make-reusable-async-conn-manager {}) | |||
| async-reuseable (conn-mgr/make-reuseable-async-conn-manager {})] | |||
There was a problem hiding this comment.
There should either be a second assertion below for the async-reuseable , or only the correctly spelled one should be tested here.
This addresses a naming inconsistency in conn mgr functions.
ptuckey
force-pushed
the
482_make-reusable-async-wrapper
branch
from
01b471e to
4af6c33
Compare
|
Merged this, thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a naming inconsistency in conn mgr functions.