Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Make compatible with graalvm #543

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Make compatible with graalvm #543

merged 1 commit into from
Jun 25, 2020

Conversation

Naomarik
Copy link
Contributor

Hi!

This small change allows me to include this awesome library in a native GraalVM binary.
Here's the related issue: oracle/graal#1074
All tests pass for me.

rymndhng
rymndhng approved these changes Jun 16, 2020
View reviewed changes
Copy link
Collaborator

@rymndhng rymndhng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good! It also aligns with how the other stateful objects are constructed.

@rymndhng
Copy link
Collaborator

@dakrone do you have any additional thoughts on this ticket?

dakrone
dakrone approved these changes Jun 16, 2020
View reviewed changes
Copy link
Owner

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this seems like a good and reasonable change

@rymndhng rymndhng merged commit 8f84a39 into dakrone:3.x Jun 25, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@rymndhng rymndhng rymndhng approved these changes

@dakrone dakrone dakrone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Naomarik @rymndhng @dakrone