Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bugfix: avoid that GitHub Action workflow strategy expansion exceeds 256 results #687

Merged

Conversation

lenvm
Copy link
Collaborator

@lenvm lenvm commented Dec 20, 2024

What

This PR updates the GitHub Action workflow that compiles all battery and inverter combinations.

Why

Currently the "Compile all combinations" workflow fails, with the error Strategy expansion exceeded 256 results for job 'build-matrix'. See Compile All Combinations | v7.9.2 #159 as an example.

This PR avoids that GitHub Action workflow strategy expansion exceeds 256 results for job build-matrix

How

It does this by splitting the workflow into two parts:

  • Part 1: batteries starting with A-N
  • Part 2: batteries starting with M-Z

…t the strategy expansion exceeds 256 results for job build-matrix
Copy link
Owner

@dalathegreat dalathegreat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we are taking lots of resources running all these tests 😅

@lenvm lenvm merged commit b14bbde into dalathegreat:main Dec 20, 2024
46 checks passed
@lenvm lenvm deleted the feature/split-compile-all-combinations-workflow branch December 20, 2024 12:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants