Indicate that SMA inverter allows contactor closing via LED #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenvm
force-pushed
the
feature/add-sma-contactor-endable-led-pin
branch
from
4e44679 to
7d9f8cf
Compare
dalathegreat
approved these changes
Dec 28, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR implements turning on/off an LED pin to indicate that SMA inverter allows/does not allow contactor closing, respectively.
To make use of the implemented code, a GPIO pin must be defined in the hardware file used. For instance
#define INVERTER_CONTACTOR_ENABLE_LED_PIN GPIO_NUM_2can be defined inhw_liligo.hwhen using one of the SD card pins for the LED.Why
This PR is implemented to get visual information if the SMA inverter request to close the contactors is sent and recognized up by the battery emulator.
How
The code checks whether the SMA inverter allows contactor closing, and turns on an LED when the inverter allows contactor closing, and turns off the LED when the inverter does not allow contactor closing.