Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add wake up pin for second BMW I3 battery #712

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Add wake up pin for second BMW I3 battery #712

merged 1 commit into from
Dec 30, 2024

Conversation

lenvm
Copy link
Collaborator

@lenvm lenvm commented Dec 29, 2024

What

This PR implements a Wake up pin for a second battery (DOUBLE_BATTERY) for BMW I3 (BMW_I3_BATTERY).

Why

This PR fixes #626. This feature was requested by pmajor021.

How

  • The WUP_PIN is updated to WUP_PIN1 and WUP_PIN2.
  • The pin definition is moved from the battery file to the hardware abstraction layer of each supported hardware.
  • Error handling is implemented, in case the pins defined as wake up pin, are also used for contactor control.

@lenvm lenvm requested a review from dalathegreat December 29, 2024 20:17
@dalathegreat dalathegreat merged commit 688952c into dalathegreat:main Dec 30, 2024
47 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dalathegreat dalathegreat dalathegreat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dual 15WUP-signal for dual BMW i3 batteries
2 participants
@lenvm @dalathegreat