Fix bugs in printf logging code & add version to log #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix printf end of line detection - Fix overwriting of timestamp in printf path - Add version + build date/time to log
No-Signal
reviewed
Jan 3, 2025
Move logging of version/data/time to setup() to ensure it is also printed to serial.
No-Signal
approved these changes
Jan 5, 2025
dalathegreat
approved these changes
Jan 5, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix bugs in printf logging code & add Battery Emulator version and build date/time to log
Why
Fix the bug and being able to see the exact build version that is running
How
Fixed the code. Added printf containing version and date/time.