Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Improvement: Reduce sketch size #770

Merged
merged 12 commits into from
Jan 10, 2025
Merged

Improvement: Reduce sketch size #770

merged 12 commits into from
Jan 10, 2025

Conversation

dalathegreat
Copy link
Owner

@dalathegreat dalathegreat commented Jan 8, 2025 •
edited
Loading

What

This PR implements a few optimizations to reduce sketch and RAM usage

Why

We are soon running out of sketch space

How

This PR performs the following optimizations, for a total of -0.2% reduction of sketch usage

  • Unused LED state (rainbow) removed from code
  • Datatypes optimized in uptime library
  • Unused code removed from Events
  • Unnecessary text removed from all events
  • Unnecessary files removed from the codebase

@dalathegreat dalathegreat changed the title Improvement/sketch size Improvement: Reduce sketch size Jan 8, 2025
No-Signal
No-Signal approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@No-Signal No-Signal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and all seems to be working

@dalathegreat dalathegreat merged commit 4912c01 into main Jan 10, 2025
104 checks passed
@dalathegreat dalathegreat deleted the improvement/sketch-size branch January 10, 2025 07:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@No-Signal No-Signal No-Signal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dalathegreat @No-Signal