Feature: Add limiting factor to Webserver #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvgalen
reviewed
Feb 12, 2025
| content += " (Inverter limiting)</h4>"; | ||
| } else { | ||
| //Note, this can also be settings limiting | ||
| content += " (Battery limiting)</h4>"; |
There was a problem hiding this comment.
Would an if/else here for settings_limiting not be a good idea?
There was a problem hiding this comment.
Yes good idea. Added this check in e4ac6d7
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR implements an user requested feature, Webserver to show what is limiting power in/out of the battery.
Why
Feature requested by Discord users
How
We implement a few new variables to the datalayer
Based on these, we show in the Webserver when the charge/discharge amperage values are limited by the battery itself (BMS), or by the user configurable settings (Manual)
We also show if the Inverter or the Battery is the limiting factor, at the Battery Charging/Discharging text, using the following variables