Remove serial-link (double LilyGo) functionality #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR removes serial-link, the ability to use 2x LilyGo boards together
If you are relying on this feature, consider switching to any of the following options:
Why
This functionality was developed before we had any good hardware solutions for adding CAN channels. It was unmaintained, and could cause overcharging/undercharging. It has many bugs (for instance Events are a mess) and nobody maintains this legacy option. In order to make the Battery-Emulator safer, we now remove this dangerous feature.
How
We remove it since it is not safe