fix(api): Use query params instead of body #139
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Description
The getVideoStatistics arguments were passed using body, but the Bunny API uses query string for this method.
The consequence was to have no argument passed to the API and return a global information (the whole library) instead of a specific video by its GUID.
The fix changes where the data are put: in the query string instead of the body.
✅ Checks
ℹ Additional Information
The tests should have seen it but the cost to update the test for this case is high: it would require to upload 2 videos (easy) but also to simulate watch time (harder) to distinguish between the global stats and the specific stats which have both '0' values because no watch time is set.
To me it's not worth it.