Fixes scrollListener accesses properties of null #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danbovey Any update on this pull request? |
unematiii
reviewed
Apr 16, 2024
| @@ -207,7 +215,8 @@ export default class InfiniteScroll extends Component { | |||
| } | |||
| } else if (this.props.isReverse) { | |||
| offset = parentNode.scrollTop; | |||
| } else { | |||
| } else if (el) { | |||
There was a problem hiding this comment.
Why is else if needed? Isn't el a ref for this.scrollComponent?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you @qhuynh96 for the fix,
the change in this PR is already done in
#267
this PR is just copying the changes from /src to /dist
(this PR can be closed if 267 has been approved and merged)