-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
🚀 Configurable timestamp output format in git blame #1157
Comments
Hi @mliszcz, thanks! I agree with the feature proposal and I think that your proposed API is spot-on. Please do go ahead and make a PR if you have time, and let me know if anything's unclear about the development workflow. |
New CLI/config option is introduced: blame-timestamp-output-format. Fixes dandavison#1157.
Thanks. I've just opened a PR. Please review carefully because I'm doing rust for the first time! I guess the formatter job will most likely fail, I will run that tomorrow and eventually amend the commit. |
New CLI/config option is introduced: blame-timestamp-output-format. Fixes dandavison#1157.
Ready. @dandavison please have a look and trigger the pipeline when you find some time. |
New CLI/config option is introduced: blame-timestamp-output-format. Fixes dandavison#1157.
New CLI/config option is introduced: blame-timestamp-output-format. Fixes #1157.
In git blame I noticed this:

It would be helpful to know e.g. which change was applied first but this can not be figured out from the humanized timestamp.
delta/src/handlers/blame.rs
Line 273 in 738c5a1
I changed it locally to:
blame.time.format("%H:%M %Y-%m-%d").to_string(),
.Would it be possible to make this configurable? Perhaps a new option --blame-output-timestamp-format could be added. If present (and not empty) it would be used as a format string. If not, we will fall back to HumanTime formatting. What do you think?
I can work on a PR if this could be accepted.
The text was updated successfully, but these errors were encountered: