Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

measure_text_width() without constructing a temporary string #1216

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

th1000s
Copy link
Collaborator

@th1000s th1000s commented Oct 24, 2022

The improvement probably can't be measured, but still feels right :)

@dandavison
Copy link
Owner

Agreed, thanks! cc @zhiburt who is using code from this module in ansitok and tabled and hence it is being used in display of all tabular data by nushell. (There's been an emphasis on performance in that work.)

@dandavison dandavison merged commit 970000f into dandavison:master Oct 24, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants