Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

CSS { text-decoration: line-through; } doesn't work properly #136

Closed
izhenka opened this issue Oct 5, 2017 · 1 comment
Closed

CSS { text-decoration: line-through; } doesn't work properly #136

izhenka opened this issue Oct 5, 2017 · 1 comment

Comments

@izhenka
Copy link

izhenka commented Oct 5, 2017 •
edited
Loading

CSS property { text-decoration: line-through; } (and "del" tag) doesn't work properly both in sandbox and in actual generated PDF. See picture
image

test case
alebar added a commit to alebar/openhtmltopdf that referenced this issue Nov 11, 2017
@alebar
Fix danfickle#136: use positive values for max comparision of striket…
a5ac9cc 
…hrough offset
@alebar alebar mentioned this issue Nov 11, 2017
Closed
danfickle added a commit that referenced this issue Nov 25, 2017
@danfickle
For #148 #136 #143 - Fix incorrect strikethrough offset calculation
870d326 
Thanks @backslash47 and @alebar
danfickle added a commit that referenced this issue Nov 25, 2017
@danfickle
For #148 #136 #143 - Fix incorrect use of Float.MIN_VALUE and update …
48b089f 
…README with strikethrough fix.
@danfickle
Copy link
Owner

Should be fixed. I'll try to do a release tomorrow.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danfickle @izhenka