Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

text-align: justify causes NullPointerException when using <br /> in <span>-tags #420

Closed
dudeltrieb opened this issue Nov 27, 2019 · 0 comments
Closed

text-align: justify causes NullPointerException when using <br /> in <span>-tags #420

dudeltrieb opened this issue Nov 27, 2019 · 0 comments

Comments

@dudeltrieb
Copy link

dudeltrieb commented Nov 27, 2019 •
edited
Loading

Hi,

I have a problem when using
tags inside of span tags when the paragraph has text-align: justified. I'am using Verions 1.0.1 (no problem in 1.0.0).

HTML Code (no other code is used is used to reproduce the problem)

<html>
  <head>
  </head>
  <body>
    <p style="text-align: justify">
      <span>foo<br />bar</span>
    </p>
  </body>
</html>

StackTrace

Caused by: com.myCompany.mySystem.documentrenderer.renderer.DocumentRendererException: Error when rendering pdf document.
	at com.myCompany.mySystem.documentrenderer.renderer.impl.DefaultDocumentRenderer.renderPdfDocumentByHtml(DefaultDocumentRenderer.java:83)
	at com.myCompany.mySystem.documentrenderer.renderer.impl.DefaultDocumentRenderer.renderPdfDocumentByHtml(DefaultDocumentRenderer.java:54)
	at com.myCompany.mySystem.documentrenderer.tags.RenderPdfTag.doEndTag(RenderPdfTag.java:90)
	at org.apache.jsp.tag.web.document.template.document_tag._jspx_meth_document_005fpdf_005f0(document_tag.java:289)
	at org.apache.jsp.tag.web.document.template.document_tag.doTag(document_tag.java:168)
	at org.apache.jsp.WEB_002dINF.views.responsive.documents.order.modelContract_jsp._jspx_meth_template_005fdocument_005f0(modelContract_jsp.java:127)
	at org.apache.jsp.WEB_002dINF.views.responsive.documents.order.modelContract_jsp._jspService(modelContract_jsp.java:92)
	... 147 more
Caused by: java.lang.NullPointerException
	at com.openhtmltopdf.render.InlineText.calcTotalAdjustment(InlineText.java:316)
	at com.openhtmltopdf.render.InlineLayoutBox.adjustHorizontalPosition(InlineLayoutBox.java:911)
	at com.openhtmltopdf.render.InlineLayoutBox.adjustHorizontalPosition(InlineLayoutBox.java:922)
	at com.openhtmltopdf.render.InlineLayoutBox.adjustHorizontalPosition(InlineLayoutBox.java:922)
	at com.openhtmltopdf.render.LineBox.adjustChildren(LineBox.java:270)
	at com.openhtmltopdf.render.LineBox.justify(LineBox.java:257)
	at com.openhtmltopdf.render.BlockBox.justifyText(BlockBox.java:1204)
	at com.openhtmltopdf.render.BlockBox.layoutInlineChildren(BlockBox.java:1197)
	at com.openhtmltopdf.render.BlockBox.layoutChildren(BlockBox.java:1171)
	at com.openhtmltopdf.render.BlockBox.layout(BlockBox.java:1028)
	at com.openhtmltopdf.render.BlockBox.layout(BlockBox.java:943)
	at com.openhtmltopdf.layout.BlockBoxing.layoutBlockChild0(BlockBoxing.java:321)
	at com.openhtmltopdf.layout.BlockBoxing.layoutBlockChild(BlockBoxing.java:299)
	at com.openhtmltopdf.layout.BlockBoxing.layoutContent(BlockBoxing.java:90)
	at com.openhtmltopdf.render.BlockBox.layoutChildren(BlockBox.java:1174)
	at com.openhtmltopdf.render.BlockBox.layout(BlockBox.java:1028)
	at com.openhtmltopdf.render.BlockBox.layout(BlockBox.java:943)
	at com.openhtmltopdf.layout.BlockBoxing.layoutBlockChild0(BlockBoxing.java:321)
	at com.openhtmltopdf.layout.BlockBoxing.layoutBlockChild(BlockBoxing.java:299)
	at com.openhtmltopdf.layout.BlockBoxing.layoutContent(BlockBoxing.java:90)
	at com.openhtmltopdf.render.BlockBox.layoutChildren(BlockBox.java:1174)
	at com.openhtmltopdf.render.BlockBox.layout(BlockBox.java:1028)
	at com.openhtmltopdf.render.BlockBox.layout(BlockBox.java:943)
	at com.openhtmltopdf.layout.BlockBoxing.layoutBlockChild0(BlockBoxing.java:321)
	at com.openhtmltopdf.layout.BlockBoxing.layoutBlockChild(BlockBoxing.java:299)
	at com.openhtmltopdf.layout.BlockBoxing.layoutContent(BlockBoxing.java:90)
	at com.openhtmltopdf.render.BlockBox.layoutChildren(BlockBox.java:1174)
	at com.openhtmltopdf.render.BlockBox.layout(BlockBox.java:1028)
	at com.openhtmltopdf.render.BlockBox.layout(BlockBox.java:943)
	at com.openhtmltopdf.layout.BlockBoxing.layoutBlockChild0(BlockBoxing.java:321)
	at com.openhtmltopdf.layout.BlockBoxing.layoutBlockChild(BlockBoxing.java:299)
	at com.openhtmltopdf.layout.BlockBoxing.layoutContent(BlockBoxing.java:90)
	at com.openhtmltopdf.render.BlockBox.layoutChildren(BlockBox.java:1174)
	at com.openhtmltopdf.render.BlockBox.layout(BlockBox.java:1028)
	at com.openhtmltopdf.render.BlockBox.layout(BlockBox.java:943)
	at com.openhtmltopdf.pdfboxout.PdfBoxRenderer.layout(PdfBoxRenderer.java:335)
	at com.openhtmltopdf.pdfboxout.PdfRendererBuilder.run(PdfRendererBuilder.java:40)
	at com.myCompany.mySystem.documentrenderer.renderer.impl.DefaultDocumentRenderer.renderPdfDocumentByHtml(DefaultDocumentRenderer.java:81)
	... 153 more
@syjer syjer mentioned this issue Nov 29, 2019
Merged
danfickle added a commit that referenced this issue Dec 4, 2019
@danfickle
Merge pull request #421 from syjer/420-text-align-justify-npe
19887e0 
handle NPE in justify text edge case #420
danfickle added a commit that referenced this issue Feb 20, 2020
@danfickle
Fixes #433 - Do not justify lines ending with br tag or similar.
941e465 
Also recommited test related to #420 for justifying a line when it should not for same reason.
@LAlves91 LAlves91 mentioned this issue Nov 13, 2020
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dudeltrieb