Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Speed improvements for creating multiple ROIs #1584

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nfahlgren
Copy link
Member

@nfahlgren nfahlgren commented Aug 20, 2024

Describe your changes
Creating multiple ROIs in the context of 10s of ROIs has not been an issue, but creating 100s of ROIs is slow. This PR aims to make adjustments to ROI functions to improve performance.

Type of update
Is this a: New feature or feature enhancement

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added work in progress Mark work in progress update Updates an existing feature/method labels Aug 20, 2024
@nfahlgren nfahlgren added this to the PlantCV v4.x milestone Aug 20, 2024
Copy link

deepsource-io bot commented Aug 20, 2024

Here's the code health analysis summary for commits b1a14e9..61cd937. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@nfahlgren nfahlgren added ready to review and removed work in progress Mark work in progress labels Sep 12, 2024
@nfahlgren nfahlgren modified the milestones: PlantCV v4.x, PlantCV v4.6 Sep 17, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ready to review update Updates an existing feature/method
Projects
Status: Pull Requests
Development

Successfully merging this pull request may close these issues.

1 participant