Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

go: Update version, remove go.work #12

Merged
merged 3 commits into from
Apr 8, 2024
Merged

go: Update version, remove go.work #12

merged 3 commits into from
Apr 8, 2024

Conversation

echarrod
Copy link
Collaborator

Changed

  • Go version

Removed

  • go.work: generally preferable, is used for local dev (example). I think this might be a cause for not being able to install with go install github.com/luno/danger-go/cmd/danger-go too: outside main module or its selected dependencies

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

Messages
📖 0 new files added!
📖 3 files modified!

Generated by 🚫 dangerJS against d80878c

adamhicks
adamhicks approved these changes Apr 4, 2024
View reviewed changes
@echarrod echarrod merged commit 36f6606 into main Apr 8, 2024
4 checks passed
@echarrod echarrod deleted the go-version branch April 8, 2024 15:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@adamhicks adamhicks adamhicks approved these changes

@neilgarb neilgarb Awaiting requested review from neilgarb

@wesrobin wesrobin Awaiting requested review from wesrobin

@andrewwormald andrewwormald Awaiting requested review from andrewwormald

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@echarrod @adamhicks