Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix crash at milestone.dueOn #119

Merged
merged 5 commits into from
Aug 31, 2020
Merged

Fix crash at milestone.dueOn #119

merged 5 commits into from
Aug 31, 2020

Conversation

anton46
Copy link
Contributor

@anton46 anton46 commented Aug 31, 2020

The crash happened when a PR has a milestone but the due-date has not been set.

com.squareup.moshi.JsonDataException: Non-null value 'dueOn' was null at $.danger.github.issue.milestone.due_on
	at com.squareup.moshi.kotlin.reflect.KotlinJsonAdapter.fromJson(KotlinJsonAdapter.kt:86)
	at com.squareup.moshi.JsonAdapter$2.fromJson(JsonAdapter.java:137)

Object documentation, https://docs.github.com/en/graphql/reference/objects#milestone

@anton46 anton46 changed the title Fix crash on milestone.dueOn Fix crash at milestone.dueOn Aug 31, 2020
Copy link
Member

@f-meloni f-meloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, I was just making a new release, this change will go into that one then should be out soon :)

@danger-public
Copy link

Warnings
⚠️ Big PR, try to keep changes smaller if you can

Generated by 🚫 Danger Kotlin against d2192ea

@f-meloni f-meloni merged commit e1c954b into danger:master Aug 31, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants