Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Road to 1.0 - Migrate from java.util.Date to kotlinx.datetime #147

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Road to 1.0 - Migrate from java.util.Date to kotlinx.datetime #147

merged 1 commit into from
Dec 4, 2020

Conversation

gianluz
Copy link
Member

@gianluz gianluz commented Nov 30, 2020

No description provided.

gianluz
gianluz commented Nov 30, 2020
View reviewed changes
danger-kotlin-library/src/main/kotlin/systems/danger/kotlin/models/serializers/DateUtils.kt
Comment on lines +7 to 8
@SuppressWarnings("unused")
internal fun fromISO8601UTC(dateStr: String): Date? {
Copy link
Member Author

@gianluz gianluz Nov 30, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping at the moment, can be removed when the migration succeed

@github-actions
Copy link

Warnings
⚠️

Any Changes To Library Code Should Be Reflected In The Changelog.

Please Consider Adding A Note There And Adhere To The Changelog Guidelines.

Generated by 🚫 Danger Kotlin against cfa7450

@danger-public
Copy link

Warnings
⚠️

Any Changes To Library Code Should Be Reflected In The Changelog.

Please Consider Adding A Note There And Adhere To The Changelog Guidelines.

Generated by 🚫 Danger Kotlin against cfa7450

@gianluz gianluz merged commit d8cbbb7 into master Dec 4, 2020
@gianluz gianluz deleted the migrate-from-java-time-to-kotlinx-datetime branch December 4, 2020 19:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@f-meloni f-meloni f-meloni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gianluz @danger-public @f-meloni