-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add BitbucketCloud support #214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great thank you very much for your PR!
Mind just add an entry to the CHANGELOG? Thank you very much! |
@gianluz done) |
@f-meloni do you have any estimate when it could be merged? |
Merged! :) |
@f-meloni cool) Can I get snapshot or beta version with BitBucket cloud support? |
@vchernyshov let me draft a release for it :) |
@vchernyshov 1.1.0 should be released now :) |
@f-meloni thanks a lot!) one more question: how I can use models from danger-kotlin-library in my own plugin? |
I think the simplest way is to pass the values to the function you use to invoke your plugin. So if you have something like package com.test.myawesomeplugin
import systems.danger.kotlin.sdk.DangerPlugin
object MyAwesomeDangerPlugin : DangerPlugin() {
override val id: String
get() = this.javaClass.name
fun helloPlugin() {
...
}
} you can make helloPlugin take the values you need, for example the base branch name, and then pass it when you invoke it from Danger register plugin MyAwesomePlugin
val danger = Danger(args)
MyAwesomePlugin.helloPlugin(danger.github...) |
This PR add support of BitBucketCloud support