Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make approvals_before_merge to be nullable #227

Merged
merged 2 commits into from
Jul 17, 2022
Merged

Make approvals_before_merge to be nullable #227

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d3e688
Make approvals_before_merge to be nullable. Closes #226.
Jun 7, 2022
4926915
Update CHANGELOG.md
pinguinjkeke Jun 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -12,6 +12,9 @@
-->
## Master

# 1.1.1
- Make GitLab approvals_before_merge variable nullable [#227](https://github.com/danger/kotlin/pull/227)

# 1.1.0

- Add support of BitBucketCloud [@vchernyshov] - [#214](https://github.com/danger/kotlin/pull/214)
2 changes: 1 addition & 1 deletion danger-kotlin-library/src/main/kotlin/systems/danger/kotlin/models/gitlab/GitLab.kt
View file
Original file line number Diff line number Diff line change
@@ -38,7 +38,7 @@ data class GitLabMergeRequest(
@SerialName("allow_maintainer_to_push")
val allowMaintainerToPush: Boolean = false,
@SerialName("approvals_before_merge")
val approvalsBeforeMerge: Int = 0,
val approvalsBeforeMerge: Int? = 0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also update the CHANGELOG?

Copy link
Contributor Author

@pinguinjkeke pinguinjkeke Jun 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Can't figure out what's wrong with the pipelines

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fails on e: Unable to compile C bridges

val assignee: GitLabUser? = null,
val author: GitLabUser,
@SerialName("changes_count")