Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add exec utils function #97

Merged
merged 2 commits into from
May 24, 2020
Merged

Add exec utils function #97

merged 2 commits into from
May 24, 2020

Conversation

f-meloni
Copy link
Member

No description provided.

@danger-public
Copy link

Warnings
⚠️

Any Changes To Library Code Should Be Reflected In The Changelog.

Please Consider Adding A Note There And Adhere To The Changelog Guidelines.

Generated by 🚫 Danger Kotlin against 6af66ba

@github-actions
Copy link

Warnings
⚠️

Any Changes To Library Code Should Be Reflected In The Changelog.

Please Consider Adding A Note There And Adhere To The Changelog Guidelines.

Generated by 🚫 Danger Kotlin against 6af66ba

Copy link
Member

@gianluz gianluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -6,4 +6,13 @@ class Utils {
fun readFile(path: String): String {
return File(path).readText()
}

fun exec(command: String, arguments: Array<String> = arrayOf()): String {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about add some javadoc on these?

@f-meloni
Copy link
Member Author

Will do a separate PR for the Javadoc

@f-meloni f-meloni merged commit a2070ca into master May 24, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants