Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Peril can post twice in quick succession #371

Closed
orta opened this issue Sep 3, 2018 · 5 comments
Closed

Peril can post twice in quick succession #371

orta opened this issue Sep 3, 2018 · 5 comments

Comments

@orta
Copy link
Member

orta commented Sep 3, 2018

I wonder if this is lots of PR events at the same time: artsy/README#32

@orta
Copy link
Member Author

orta commented Sep 3, 2018

Yep: Making a PR and assigning someone before hitting publish opens the PR as two events, so two webhooks come in at the same time.

I wonder if I can debounce the pull request events?

@orta
Copy link
Member Author

orta commented Sep 7, 2018

I had a think about this last night, perhaps I can make a plugin which surpasses the assigned issue if the assigned date is the same as the issue created date

@orta
Copy link
Member Author

orta commented Sep 8, 2018

Three times, in theory, "action": "review_requested"

@orta
Copy link
Member Author

orta commented Sep 8, 2018

That review requested is per person too, so it's effectively a lot of dupes.

@orta
Copy link
Member Author

orta commented Sep 8, 2018

I think it might be better to switch "pull_request" to act like how withspectrum's being doing it.

e.g. pull_request is treated as pull_request.opened, pull_request.synchronize, pull_request.edited.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant