Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adds comments to the inline walkthrough #32

Merged
merged 2 commits into from
Sep 8, 2018
Merged

Adds comments to the inline walkthrough #32

merged 2 commits into from
Sep 8, 2018

Conversation

orta
Copy link
Contributor

@orta orta commented Sep 3, 2018

This denotes:

  • Team standup are optional
  • That open RFCs are already published In the dev channel
  • That if you're unsure about L&Ls then you can always asking the L&L channel

@peril-staging
Copy link
Contributor

peril-staging bot commented Sep 3, 2018

Typos for open-standup.md

Line Typo
20 > @persona @personB reminder, we're looking for a
Got false positives?

Make changes to the global settings spellcheck.json in /artsy/peril-settings.

Make changes to this repo's settings in spellcheck.json.

Generated by 🚫 dangerJS

1 similar comment
@peril-staging
Copy link
Contributor

peril-staging bot commented Sep 3, 2018

Typos for open-standup.md

Line Typo
20 > @persona @personB reminder, we're looking for a
Got false positives?

Make changes to the global settings spellcheck.json in /artsy/peril-settings.

Make changes to this repo's settings in spellcheck.json.

Generated by 🚫 dangerJS

@orta
Copy link
Contributor Author

orta commented Sep 7, 2018

@ashfurrow ^

Copy link
Contributor

@ashfurrow ashfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Might want to add “NYC time” to “9am”, up to you!

@orta orta merged commit 0ad71ca into master Sep 8, 2018
@dblock dblock deleted the orta-add-comments branch September 14, 2018 01:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants