Fix icon redirect not working on desktop #5536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dani-garcia
reviewed
Feb 3, 2025
tessus
reviewed
Feb 3, 2025
Gerardv514
reviewed
Feb 3, 2025
BlackDex
force-pushed
the
fix-icon-redirect
branch
from
a2d7649 to
749c022
Compare
Gerardv514
approved these changes
Feb 4, 2025
tessus
approved these changes
Feb 4, 2025
We also need to exclude the header in case we do an external_icon call. Fixes dani-garcia#5535 Signed-off-by: BlackDex <black.dex@gmail.com>
Signed-off-by: BlackDex <black.dex@gmail.com>
Signed-off-by: BlackDex <black.dex@gmail.com>
BlackDex
force-pushed
the
fix-icon-redirect
branch
from
749c022 to
2d46c20
Compare
dani-garcia
approved these changes
Feb 4, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also need to exclude the header in case we do an external_icon call.
Fixes #5535