Skip to content

Commit

Permalink
SummaryList: Improve types
Browse files Browse the repository at this point in the history
  • Loading branch information
daniel-ac-martin committed May 1, 2023
1 parent 4e4d590 commit 0338c66
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions components/summary-list/src/SummaryListContainer.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { FC, createElement as h } from 'react';
import { FC, HTMLAttributes, createElement as h } from 'react';
import { StandardProps, classBuilder } from '@not-govuk/component-helpers';

export type SummaryListContainerProps = StandardProps & {
export type SummaryListContainerProps = StandardProps & HTMLAttributes<HTMLDListElement> & {
};

export const SummaryListContainer: FC<SummaryListContainerProps> = ({
Expand Down
4 changes: 2 additions & 2 deletions components/summary-list/src/SummaryListItem.tsx
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import { FC, ReactNode, createElement as h } from 'react';
import { FC, HTMLAttributes, ReactNode, createElement as h } from 'react';
import { Anchor, AnchorList } from '@not-govuk/anchor-list';
import { A } from '@not-govuk/link';
import { StandardProps, classBuilder } from '@not-govuk/component-helpers';

export type Action = Anchor;

export type SummaryListItemProps = StandardProps & {
export type SummaryListItemProps = StandardProps & HTMLAttributes<HTMLDivElement> & {
/** Name or 'key' of the item */
name: ReactNode | string
/** Value of the item */
Expand Down

1 comment on commit 0338c66

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please # to comment.