Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update Node.js to v18 #705

Merged
merged 4 commits into from
Feb 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/setup/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ inputs:
node:
description: The version of Node.js to use.
required: false
default: 16
default: 18
frozen-lockfile:
description: Whether to require a frozen lock-file
required: false
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/change-assurance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
- name: Setup
uses: ./.github/actions/setup
with:
node: 16
node: 18

- name: Build libraries
run: npm run libs:build
Expand All @@ -70,7 +70,7 @@ jobs:
- name: Setup
uses: ./.github/actions/setup
with:
node: 16
node: 18

- name: Build
uses: ./.github/actions/build-app
Expand Down Expand Up @@ -102,7 +102,7 @@ jobs:
- name: Setup
uses: ./.github/actions/setup
with:
node: 16
node: 18

- name: Download build directory
uses: actions/download-artifact@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy-to-heroku.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ jobs:
cypress-project-id: ${{ secrets.CYPRESS_PROJECT_ID }}
cypress-record-key: ${{ secrets.CYPRESS_RECORD_KEY }}
deployment: heroku
node: 16
node: 18
smoke: true

- name: Scan service for vulnerabilities
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy-to-netlify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ jobs:
cypress-project-id: ${{ secrets.CYPRESS_PROJECT_ID }}
cypress-record-key: ${{ secrets.CYPRESS_RECORD_KEY }}
deployment: netlify
node: 16
node: 18
smoke: true

- name: Scan service for vulnerabilities
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- name: Setup
uses: ./.github/actions/setup
with:
node: 16
node: 18

- name: Push Storybook to Chromatic
uses: chromaui/action@v1
Expand All @@ -33,7 +33,7 @@ jobs:
uses: './.github/workflows/deploy-to-netlify.yml'
with:
app: govuk-docs
node: 16
node: 18
production-branch: master
secrets:
CYPRESS_PROJECT_ID: ${{ secrets.CYPRESS_PROJECT_ID }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Setup
uses: ./.github/actions/setup
with:
node: 16
node: 18
frozen-lockfile: true

- name: Publish
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/static-security-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- name: Setup
uses: ./.github/actions/setup
with:
node: 16
node: 18

- name: Scan dependencies
uses: ./.github/actions/scan-dependencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-built-files.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Setup
uses: ./.github/actions/setup
with:
node: 16
node: 18

- name: Scan dependencies
uses: ./.github/actions/scan-dependencies
Expand Down
2 changes: 1 addition & 1 deletion apps/govuk-docs/aws.serverless.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
service: govuk-docs
provider:
name: aws
runtime: nodejs16.x
runtime: nodejs18.x
environment:
MODE: serverless
NODE_ENV: production
Expand Down
2 changes: 1 addition & 1 deletion apps/govuk-docs/src/server/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const serverConfig = {
level: process.env.LOG_LEVEL || 'info'
},
httpd: {
host: process.env.LISTEN_HOST || '0.0.0.0',
host: process.env.LISTEN_HOST || '::',
port: Number(process.env.PORT) || Number(process.env.LISTEN_PORT) || 8080
},
mode: (process.env.MODE || 'server') as Mode,
Expand Down
2 changes: 1 addition & 1 deletion apps/govuk-template/aws.serverless.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
service: govuk-template
provider:
name: aws
runtime: nodejs16.x
runtime: nodejs18.x
environment:
MODE: serverless
NODE_ENV: production
Expand Down
2 changes: 1 addition & 1 deletion apps/govuk-template/src/server/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const serverConfig = {
level: process.env.LOG_LEVEL || 'info'
},
httpd: {
host: process.env.LISTEN_HOST || '0.0.0.0',
host: process.env.LISTEN_HOST || '::',
port: Number(process.env.PORT) || Number(process.env.LISTEN_PORT) || 8080
},
mode: (process.env.MODE || 'server') as Mode,
Expand Down
2 changes: 1 addition & 1 deletion lib/plop-pack/skel/app/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ COPY package.json /app/
COPY dist/ /app/dist/

USER 31337
ENV LISTEN_HOST="0.0.0.0" \
ENV LISTEN_HOST="::" \
LISTEN_PORT="8080" \
SSR_ONLY="false" \
SESSIONS_SECRET="changeme" \
Expand Down
2 changes: 1 addition & 1 deletion lib/plop-pack/skel/app/aws.serverless.yml.hbs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
service: {{{ name }}}
provider:
name: aws
runtime: nodejs16.x
runtime: nodejs18.x
environment:
MODE: serverless
NODE_ENV: production
Expand Down
2 changes: 1 addition & 1 deletion lib/plop-pack/skel/app/src/server/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const serverConfig = {
level: process.env.LOG_LEVEL || 'info'
},
httpd: {
host: process.env.LISTEN_HOST || '0.0.0.0',
host: process.env.LISTEN_HOST || '::',
port: Number(process.env.PORT) || Number(process.env.LISTEN_PORT) || 8080
},
mode: (process.env.MODE || 'server') as Mode,
Expand Down