Telemetry for Elasticsearch API calls #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Telemetry support for all API requests, following `:telemetry.span` convention. For context, what this patch aims as goal is to produce automatic OpenTelemetry instrumentation, following [semantic traces for DBs][1]. [1]: https://github.com/open-telemetry/opentelemetry-specification/blob/10dddf56f1643150a90daee13076be68852c40d3/specification/trace/semantic_conventions/database.md
|
Sorry to ping @danielberkompas, any thoughts on this PR? We would love to have theses :telemetry events as we're mass adopting OpenTelemetry at our company :) |
danielberkompas
approved these changes
Oct 1, 2022
|
Sorry for the long delay here. Looks good, I'm happy to accept this. |
|
Thank you! 🙇 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Telemetry support for all API requests, following
:telemetry.span/3convention.For context, what this patch aims as goal is to produce automatic OpenTelemetry instrumentation, following semantic traces for DBs.