Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

consistent packaging versions; build group #770

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

corneliusdavid
Copy link
Contributor

While working with Delphi 12 packages between debug and release, I found some package suffix still using 110, some using 113; recommendation these days is to use $(Auto) and Delphi will manage it based on the version.

Also added a build group to compile both Debug and Release configurations of both Win32 and Win64 platforms of the libraries.

(it looks like iOS platforms were inadvertently added by Delphi)

@danieleteti danieleteti merged commit 63927cc into danieleteti:master Sep 3, 2024
@danieleteti
Copy link
Owner

Thank you @corneliusdavid

@danieleteti danieleteti added this to the 3.4.2-magnesium milestone Sep 3, 2024
@danieleteti danieleteti added enhancement accepted Issue has been accepted and inserted in a future milestone labels Sep 3, 2024
danieleteti added a commit that referenced this pull request Sep 6, 2024
@danieleteti
Copy link
Owner

Thanks for your point, but $(Auto) is reliable supported since Delphi 11 (10.4.2 but it's too complex to handle such mid-version). Currently we support Delphi since version 10 Seattle, so handling different naming for 4 packages (dmvc, dmvcdesigntime, loggerpro, swagdoc) is too complex for the actual benefits. Also becouse SwagDoc doesn't handle itself number versioning so we should change the naming and the folder structure which eventually makes the upgrade phase more complex. We0ll postpone this update to when the older version to support is D11. Thanks

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
accepted Issue has been accepted and inserted in a future milestone enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants