Mysql provider tests #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielgerlag
approved these changes
Dec 28, 2018
| "jasmine": "^3.3.1", | ||
| "jasmine-core": "^3.3.0", | ||
| "jasmine": "^2.5.2", | ||
| "jasmine-core": "^2.4.1", |
There was a problem hiding this comment.
why did you need to downgrade jasmine?
There was a problem hiding this comment.
It was a test to see if this was the problem with the docker auth. I forgot to upgrade it.
|
I didn't have time to look at it this week. I'll do it as soon as I can. But I have some ideas to look for. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Daniel. I'm opening this pull request to add the tests to my-sql-provider, however, I'm getting errors with MySQL authentication with docker. And if you could review some test specs that I've written.