fix(api): Do not cache server responses when refreshing API defs #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also ignores any CLI or env parameters passed in when querying for API definitions: only profile specified params are used. Fixes danielgtaylor#216
Codecov Report
@@ Coverage Diff @@
## main #225 +/- ##
==========================================
- Coverage 76.92% 76.90% -0.02%
==========================================
Files 26 26
Lines 3666 3663 -3
==========================================
- Hits 2820 2817 -3
Misses 639 639
Partials 207 207
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
danielgtaylor
approved these changes
Dec 14, 2023
|
No worries, I know you will get to these eventually. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also ignores any CLI or env parameters passed in when querying for API definitions: only profile specified params are used.
I also took the liberty of refactoring how the options work.
Final note: the tests timeout when ran natively on mac silicon (at least on my machine). They pass in a ubuntu VM.
Fixes #216