chore: add configurable redirect_url, preserve default value #229
Conversation
| @@ -234,8 +243,12 @@ func (ac *AuthorizationCodeTokenSource) Token() (*oauth2.Token, error) { | |||
| c: codeChan, | |||
| } | |||
|
|
|||
| // strip protocol prefix from configured redirect url for local webserver | |||
There was a problem hiding this comment.
I'm noodling on whether it would be better to do something like
u, _ := url.Parse(ac.getRedirectUrl())
redirectServer := fmt.Sprintf("%s:%d", u.Hostname(), u.Port())
Any thoughts?
There was a problem hiding this comment.
That's probably better than the trim calls. I do wonder though if we should be using the configured hostname or always use localhost instead... like what if the hostname doesn't resolve to localhost? 🤔 I suppose it doesn't matter for our use-case so could always be modified later.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #229 +/- ##
=======================================
Coverage 76.92% 76.92%
=======================================
Files 26 26
Lines 3666 3666
=======================================
Hits 2820 2820
Misses 639 639
Partials 207 207 Continue to review full report in Codecov by Sentry.
|
This enables users to configure a specific hostname for the auth_code callback. When not configured, the existing value (
"http://localhost:8484") is used.I chose to make this a "top-level" param given that it's listed in https://www.oauth.com/oauth2-servers/pkce/, but I would be happy to use the custom-params support instead if preferred.