Run acceptance tests directly on GitHub runners #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielparks
force-pushed
the
acceptance-without-litmus
branch
8 times, most recently
from
2e4f28a to
d384ca3
Compare
danielparks
changed the title
danielparks
force-pushed
the
acceptance-without-litmus
branch
10 times, most recently
from
3e32cd5 to
6c87098
Compare
- Simplify validation in GitHub CI. - Improve test output in GitHub CI. - Support for Ubuntu in acceptance tests. - Run acceptance tests directly on GitHub CI runners (part of #83).
danielparks
force-pushed
the
acceptance-without-litmus
branch
3 times, most recently
from
a4160cb to
9752f0f
Compare
Acceptance tests were failing on GitHub CI because its runners have `rustup` already installed in `/etc/skel`. This switches the acceptance tests to only use `managehome => false` so that `/etc/skel` is ignored when they create new users. Fixes #83 — Acceptance tests broken.
danielparks
force-pushed
the
acceptance-without-litmus
branch
from
9752f0f to
a90d1b3
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a bunch of updates, some of which actually come from my PDK template.
The big one is that it now runs acceptance tests in CI on the GitHub runners directly, rather than trying to spin up containers under Puppet Litmus.
Fixes #83 — Acceptance tests broken.