Enable building multi-arch docker images for s390x #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at enabling building multi-arch Docker images for CI and also publishing them. The
make dockertarget could still produce the same local image as the current master branch, only themake pushtarget is modified into building and publishing multi-arch images withbuildxusing cross-built binaries. Currently, only s390x is added to the target list but it will be straightforward to add other platforms as well.On a side note, setting
- GOFLAGS="-mod=readonly"and execute@$(GO) mod vendorwould make sure the CI would not fail when the module list is outdated.