Set glog levels to control verbosity #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stanislav Knot <sknot@redhat.com>
ppatierno
reviewed
Sep 15, 2021
kafka_exporter.go
Outdated
| @@ -33,6 +33,13 @@ const ( | |||
| clientID = "kafka_exporter" | |||
| ) | |||
|
|
|||
| const ( | |||
| OFF = 0 | |||
There was a problem hiding this comment.
what this OFF = 0 is? When on glog you don't use the verbosity function, it just prints the message provided to Info function so I would use INFO = 0 as default and DEBUG = 1 and TRACE = 2.
There was a problem hiding this comment.
I thought it would be good to have a possibility to disable info logging.
Signed-off-by: Stanislav Knot <sknot@redhat.com>
|
/lgtm thanks @sknot-rh and @ppatierno ! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stanislav Knot sknot@redhat.com
With this, we can control the verbosity using the
--verbosityparameter which is already present.