Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix incorrect rating-dist #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

akkerman
Copy link

before:
$ goodreads book --rating-dist "Animal Farm"
★ ★ ★ ★ ★ :
★ ★ ★ ★ ☆ : 5
★ ★ ★ ☆ ☆ :
★ ★ ☆ ☆ ☆ : 4
★ ☆ ☆ ☆ ☆ : 2

Total : 0

after:
$ goodreads book --rating-dist "Animal Farm"
★ ★ ★ ★ ★ : 745260
★ ★ ★ ★ ☆ : 774734
★ ★ ★ ☆ ☆ : 466907
★ ★ ☆ ☆ ☆ : 143818
★ ☆ ☆ ☆ ☆ : 71574

Total : 2202293

before:
$ goodreads book --rating-dist "Animal Farm"
★ ★ ★ ★ ★ :
★ ★ ★ ★ ☆ : 5
★ ★ ★ ☆ ☆ :
★ ★ ☆ ☆ ☆ : 4
★ ☆ ☆ ☆ ☆ : 2

Total : 0

after:
$ goodreads book --rating-dist "Animal Farm"
★ ★ ★ ★ ★ : 745260
★ ★ ★ ★ ☆ : 774734
★ ★ ★ ☆ ☆ : 466907
★ ★ ☆ ☆ ☆ : 143818
★ ☆ ☆ ☆ ☆ : 71574

Total : 2202293
Copy link
Owner

@danishprakash danishprakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akkerman thanks for the pr. I've to ask about the environment you're using this because this works fine for me on macOS.

@akkerman
Copy link
Author

akkerman commented Sep 14, 2018

I'm on Ubuntu, sed version 4.2.2

Example of the relevant difference:

$ echo "before|after" | sed "s/|/:/g"
before:after

$ echo "before|after" | sed "s/\|/:/g"
:b:e:f:o:r:e:|:a:f:t:e:r:

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants