kitty: kill memory leak in self-referential animation #2012

dankamongmen · Aug 2, 2021 · 46a63c5 · 46a63c5
1 parent 49729dc
commit 46a63c5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/lib/kitty.c b/src/lib/kitty.c
@@ -739,9 +739,11 @@ write_kitty_data(FILE* fp, int linesize, int leny, int lenx, int cols,
             }
             tam[tyx].auxvector = tmp;
           }else if(level == KITTY_SELFREF){
-            tam[tyx].auxvector = malloc(sizeof(tam[tyx].state));
             if(tam[tyx].auxvector == NULL){
-              goto err;
+              tam[tyx].auxvector = malloc(sizeof(tam[tyx].state));
+              if(tam[tyx].auxvector == NULL){
+                goto err;
+              }
             }
             memcpy(tam[tyx].auxvector, &tam[tyx].state, sizeof(tam[tyx].state));
           }

diff --git a/src/lib/termdesc.c b/src/lib/termdesc.c
@@ -512,7 +512,7 @@ apply_term_heuristics(tinfo* ti, const char* termname, int fd,
     if(add_smulx_escapes(ti, tablelen, tableused)){
       return -1;
     }
-    if(compare_versions(ti->termversion, "0.22.0") >= 0){
+    if(compare_versions(ti->termversion, "0.22.1") >= 0){
       setup_kitty_bitmaps(ti, fd, KITTY_SELFREF);
     }else if(compare_versions(ti->termversion, "0.20.0") >= 0){
       setup_kitty_bitmaps(ti, fd, KITTY_ANIMATION);