see whether we can kill query spill by disabling echo

[dankamongmen]

Just had an inspiration...we're plagued by terminals which fail to consume entire escapes. See, for instance, Konsole in #1888. What happens if we just disable echo for the duration of the query send? Will that prevent such unconsumed controls from showing up on the display, while allowing the others to continue to reach the terminal? If so, that ought provide a general solution to this annoyance!

[dankamongmen]

Alas, this does not appear to work.

However, a Second Idea: we're already throwing a u7 in the query string. Why not lead with u7, so that the cursor position reported is clean of any query spill? We could then always move back to that position, or throw a u7 in at the end as well, and move only if there was a difference. I don't see much point in the latter, though. Let's try that out.

[dankamongmen]

works perfectly =] w000000000t! nice!

[dankamongmen]

before: (note the cp at the very beginning)

after:

[dankamongmen]

Terminal.App befrore/after

[dankamongmen]

yay! this is a completely general solution for a long-time and varied annoyance! oh, happy happy day!

[dankamongmen]

however, this isn't going to apply as written to anything but the new CLI mode. direct mode and pure rendered mode still suffer from the problem. i'd think the thing to do is to move the goto_location() from notcurses_core_init() to interrogate_terminal().

[dankamongmen]

hrmmmm except goto_location() wants a notcurses*, erp!

[dankamongmen]

this is too sweet to give up on. alright, what we're gonna do is make goto_location() source-independent. merge it with the ncdirect variant. we might have to merge some state between the two; that's fine, shove it into tinfo, that's what it's there for.

[dankamongmen]

ugh this is gonna stomp all over the dankamongmen/fauxmemstream branch though =[

[dankamongmen]

no, ncdirect_cursor_move_yx() and goto_location() are just too fundamentally different. duplicate the check to ncdirect, and check for !inhibit_banner in rendered mode.

[dankamongmen]

confirmed fix for direct mode

[dankamongmen]

confirmed fix across all modes