Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

WhiteSource scan warning #93

Closed
Sprokopyak opened this issue May 22, 2019 · 2 comments
Closed

WhiteSource scan warning #93

Sprokopyak opened this issue May 22, 2019 · 2 comments

Comments

@Sprokopyak
Copy link

Hello,

At our Angular project we are using node-sass package for compiling files from .scss to normal .css file. Node-sass has some other dependencies and in one of them is included js-base64 packge.

On the project, we also run WhiteSource scan during the builds, and it displays an alert - "Security Vulnerability" because of using an old version of the jquery library inside js-base64/test/index.html file and as a solution to fix this problem it proposes to upgrade jquery version from 2.1.4 to 3.4.0. See at the attached screenshot.
image.

So, could you please upgrade jquery version to 3.4.0 inside js-base64/test/index.html file?

@sv3k
Copy link

sv3k commented Aug 21, 2019

We have the same warning on all the angular projects. Adding the ./test folder to .npmignore looks like an easy fix. Plus, having millions of weekly downloads for this lib, it could save gigabytes of traffic.

@dankogai
Copy link
Owner

@Sprokopyak Fixed in cf8fc4a

@sv3k adding ./test to .npmignore' breaks npm test` so I consider that too much.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants