Update AltoRouter.php for php 8.4 #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for php8.4 AltoRouter::map(): Implicitly marking parameter $name as nullable is deprecated. AltoRouter::match(): Implicitly marking parameter $requestUrl as nullable is deprecated. AltoRouter::match(): Implicitly marking parameter $requestMethod as nullable is deprecated.
|
Thanks @xpetter! Can you change the PR to use |
fix for php 8.4 and keep php 7.3 support
xpetter
commented
Dec 16, 2024
|
Nice one, thanks a lot @xpetter! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for php8.4
AltoRouter::map(): Implicitly marking parameter $name as nullable is deprecated. AltoRouter::match(): Implicitly marking parameter $requestUrl as nullable is deprecated. AltoRouter::match(): Implicitly marking parameter $requestMethod as nullable is deprecated.