Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add abstract support for classes and methods #29

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Add abstract support for classes and methods #29

merged 2 commits into from
Feb 3, 2022

Conversation

MichaelHochriegl
Copy link
Contributor

Adds support for making abstract classes and methods.

Closes #28

dansiegel
dansiegel requested changes Feb 3, 2022
View reviewed changes
Copy link
Owner

@dansiegel dansiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. it's a great improvement. I just want to be sure that this stays in line with the existing API.

src/CodeGenHelpers/ClassBuilder.cs Outdated Show resolved Hide resolved
src/CodeGenHelpers/MethodBuilder.cs Outdated Show resolved Hide resolved
Change API to reflect new style
1a55146 
Change the abstract API as requested in PR
dansiegel
dansiegel approved these changes Feb 3, 2022
View reviewed changes
Copy link
Owner

@dansiegel dansiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@dansiegel dansiegel merged commit f3f4141 into dansiegel:master Feb 3, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dansiegel dansiegel dansiegel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for abstract classes and methods
2 participants
@MichaelHochriegl @dansiegel