-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Implement _check #79
base: GeoBlaso
Are you sure you want to change the base?
Implement _check #79
Conversation
Thank you for the submission, @GeoBlaso! I'll review your code shortly, hang tight. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great attempt @GeoBlaso, you're almost there!
I've marked a few style guide violations with inline comments. Please review the comments below and make the appropriate changes. Remember, you can check your code's style locally with npm run lint
.
After you make these changes locally, commit and push them back up to your fork. When you push your changes, I'll come back for another review.
exports.add = (x, y) => { | ||
if (typeof x !== 'number') { | ||
exports._check = (x, y) => { | ||
if (typeof x !== 'number') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected indentation of 2 spaces but found 3.
See http://eslint.org/docs/rules/indent for details about this rule
exports.add = (x, y) => { | ||
if (typeof x !== 'number') { | ||
exports._check = (x, y) => { | ||
if (typeof x !== 'number') { | ||
throw new TypeError(`${x} is not a number`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected indentation of 5 spaces but found 4.
See http://eslint.org/docs/rules/indent for details about this rule
exports.add = (x, y) => { | ||
if (typeof x !== 'number') { | ||
exports._check = (x, y) => { | ||
if (typeof x !== 'number') { | ||
throw new TypeError(`${x} is not a number`); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected indentation of 3 spaces but found 2.
Pull Request for issue #1