Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove runtime dependency on pip #156

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Remove runtime dependency on pip #156

merged 1 commit into from
Oct 31, 2024

Conversation

edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented Oct 30, 2024 •
edited
Loading

Description

Closes #155

Pre-approval checklist (for submitter)

Please complete these steps

  • Passes tests
  • New tests for additional features or changed functionality
  • My name and contribution added to contributors list (or if I'd rather opt out, I've said so in the PR)

@edgarrmondragon edgarrmondragon mentioned this pull request Oct 30, 2024
Closed
danthedeckie
danthedeckie approved these changes Oct 31, 2024
View reviewed changes
Copy link
Owner

@danthedeckie danthedeckie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦
Sorry about that.

@danthedeckie danthedeckie merged commit 4552e24 into danthedeckie:main Oct 31, 2024
1 check passed
@danthedeckie danthedeckie mentioned this pull request Oct 31, 2024
Merged
@edgarrmondragon edgarrmondragon deleted the remove-pip-dep branch October 31, 2024 14:12
@edgarrmondragon
Copy link
Contributor Author

🤦 Sorry about that.

No prob, thanks for your continued maintenance of this project!

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@danthedeckie danthedeckie danthedeckie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is pip really required at runtime?
2 participants
@edgarrmondragon @danthedeckie