Skip to content

NBA-3112 : Added Contract NFT Display Data #79

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

NBA-3112 : Added Contract NFT Display Data #79

wants to merge 5 commits into from

Conversation

judezhu
Copy link
Collaborator

@judezhu judezhu commented Sep 18, 2024

No description provided.

@judezhu judezhu requested a review from a team as a code owner September 18, 2024 17:11
@judezhu judezhu changed the title Added contract nft display data NBA-3112 : Added Contract NFT Display Data Sep 18, 2024
@judezhu judezhu requested a review from Deewai September 18, 2024 17:15
Deewai
Deewai previously approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@Deewai Deewai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just a comment on the image url

joshuahannan
joshuahannan reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you also update getContractViews() to add NFTCollectionDisplay to that too

@judezhu
Copy link
Collaborator Author

judezhu commented Sep 21, 2024 •
edited
Loading

Make sure you also update getContractViews() to add NFTCollectionDisplay to that too

updated it here: 466da66 .

joshuahannan
joshuahannan approved these changes Sep 21, 2024
View reviewed changes
Copy link
Contributor

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Do you have a plan for the actual upgrade?

@judezhu
Copy link
Collaborator Author

judezhu commented Sep 21, 2024 •
edited
Loading

Thank you! Do you have a plan for the actual upgrade?

@joshuahannan just upgraded ✅ . Is there a way to check if the metadata view works on 3rd party site now?

@joshuahannan
Copy link
Contributor

Not sure. I just told the find team that y'all updated and they'll probably verify

@judezhu judezhu requested a review from Deewai October 7, 2024 17:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@joshuahannan joshuahannan joshuahannan approved these changes

@Deewai Deewai Deewai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@judezhu @joshuahannan @Deewai