-
Notifications
You must be signed in to change notification settings - Fork 202
support resources-path #1012
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
support resources-path #1012
Conversation
Signed-off-by: HueiFeng <695979933@qq.com>
Codecov Report
@@ Coverage Diff @@
## master #1012 +/- ##
==========================================
- Coverage 29.18% 29.16% -0.03%
==========================================
Files 35 35
Lines 2364 2366 +2
==========================================
Hits 690 690
- Misses 1598 1599 +1
- Partials 76 77 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: hueifeng <695979933@qq.com>
Signed-off-by: hueifeng <695979933@qq.com>
62259d2
to
4a0888a
Compare
There needs to be some clarity on next steps before this PR is merged
|
|
Currently we are using substitution in
Maybe I still need to do a lot of work and maybe we can discuss what's next and whether to make big changes to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hueifeng Can you add an E2E for the resources path flag?
Also add usage and in readme.
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Signed-off-by: HueiFeng 695979933@qq.com
Issue reference
#953
Please reference the issue this PR will close: #953
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: