-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Feature: Enable query state API #116
Conversation
Signed-off-by: Ruokun Niu <ruokunniu@microsoft.com>
Signed-off-by: Ruokun Niu <ruokunniu@microsoft.com>
Signed-off-by: Ruokun Niu <ruokunniu@microsoft.com>
adbd056
to
8e042d4
Compare
Looks good, I have two questions:
|
Signed-off-by: Mike Nguyen <hey@mike.ee>
Hi @mikeee, thanks for the comments and sorry for my late response. I'll take a look into this and update the PR |
No worries, I can update and get this pushed through if you'd prefer 👍 |
That would be great! Thanks :) |
Signed-off-by: mikeee <hey@mike.ee>
Signed-off-by: mikeee <hey@mike.ee>
Signed-off-by: mikeee <hey@mike.ee>
Signed-off-by: mikeee <hey@mike.ee>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks for the contribution @ruokun-niu, much appreciated 😄 |
Thanks for the review and help! |
@holopin-bot @ruokun-niu Thank you! |
Congratulations @ruokun-niu, you just earned a badge! Here it is: https://holopin.io/claim/clvwgjwuk38440fme3ecbo1pv This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
The query state API is an existing API that is currently in the Alpha stage. Currently, this capability is available in some other SDKs, e.g. the JavaScript SDK. In the Rust SDK, we cannot utilize the query API to fetch specific states in the
Client
Struct.This PR utilizes the existing proto messages
QueryStateRequest
andQueryStateResponse
to enable state querying. I have added a new function calledquery_state_alpha1()
that takes in two parameters:store_name
andquery
and an optional parameter:metadata
.The query can be defined using
serde_json::json
Example:
Issue #115