Add fallback handler to axum Router #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default the fallback handler now logs the path that could not be found. This can be vital for debugging, as otherwise there is no feedback on the server if a method is called that isn't registered. Signed-off-by: Leon Matthes <leon.matthes@kdab.com>
LeonMatthesKDAB
force-pushed
the
404-handler
branch
from
6be9644 to
e43b850
Compare
mikeee
reviewed
Jan 28, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By default the fallback handler now logs the path that could not be
found.
This can be vital for debugging, as otherwise there is no feedback on
the server if a method is called that isn't registered.
Issue reference
None
Checklist
I believe it shouldn't be necessary to update the documentation or add new tests (the test_actor_deactivate call already tests 404 behavior).