Merge pull request #70 from dark0dave/fix/embededEffects

fix(embed): Fix for embedded effect v1
dark0dave · Nov 13, 2024 · e5ae405 · e5ae405
2 parents 8d66e8d + 78c86dd
commit e5ae405
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 16 deletions.
diff --git a/fixtures/sw1h01.itm.json b/fixtures/sw1h01.itm.json
@@ -66,7 +66,8 @@
       "melee_animation": [50, 0, 50, 0, 0, 0],
       "is_arrow": 0,
       "is_bolt": 0,
-      "is_bullet": 0
+      "is_bullet": 0,
+      "effects": []
     }
   ],
   "equipping_feature_blocks": [

diff --git a/fixtures/zbpdnote.itm b/fixtures/zbpdnote.itm
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -2,7 +2,7 @@
   "name": "infinity-viewer",
   "displayName": "infinity-viewer",
   "description": "Infinity Viewer lets you view infinity engine binary files as json",
-  "version": "0.7.2",
+  "version": "0.8.0",
   "keywords": [
     "Infinity Engine",
     "Baldur's Gate",
@@ -28,9 +28,6 @@
   "categories": [
     "Programming Languages"
   ],
-  "activationEvents": [
-    "onCustomEditor:ie.preview"
-  ],
   "main": "./out/extension.js",
   "contributes": {
     "capabilities": {

diff --git a/src/models/itm.ts b/src/models/itm.ts
@@ -1,4 +1,8 @@
-import { feature_block_parser, header_parser } from "./common";
+import {
+  effect_v1_parser,
+  feature_block_parser,
+  header_parser,
+} from "./common";
 import { Parser } from "binary-parser";
 
 const item_header_parser = header_parser()
@@ -73,7 +77,11 @@ const extended_item_header_parser = new Parser()
   })
   .uint16le("is_arrow")
   .uint16le("is_bolt")
-  .uint16le("is_bullet");
+  .uint16le("is_bullet")
+  .array("effects", {
+    type: effect_v1_parser,
+    length: "feature_blocks_count",
+  });
 
 const parser = item_header_parser
   .array("extended_headers", {