RFC: Don't offer OpenCL "use all GPU memory" #18308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "use all GPU memory" preferences option is not helping for darktable OpenCL stability at all and won't give a significant performance gain in the vast majority of settings. Quite a number of dt failing issues on pixls.us forum are directly related to this. It should only be used in situations with more than one OpenCL device to allow specific tuning for the non-desktop devices. So let's get rid of this option if there is only one device. BTW, we can still modify the preferences setting per level ...
TurboGit
approved these changes
Jan 27, 2025
kofa73
added a commit
to kofa73/dtdocs
that referenced
this pull request
Jan 29, 2025
This was referenced Jan 29, 2025
elstoc
pushed a commit
to darktable-org/dtdocs
that referenced
this pull request
Mar 10, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "use all GPU memory" preferences option is not helping for darktable OpenCL stability at all and won't give a significant performance gain in the vast majority of settings. Quite a number of dt failing issues on pixls.us forum are directly related to this.
It should only be used in situations with more than one OpenCL device to allow specific tuning for the non-desktop devices.
So let's get rid of this option if there is only one device.
BTW, we can still modify the preferences setting per level ...