Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

New Immich export plugin #542

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

brainz73
Copy link

@brainz73 brainz73 commented Dec 2, 2024

Hi, I wrote an export plugin for Immich, an open source photo management software that is becoming very interesting:

https://immich.app/

I would like to contribute to the Darktable project by sharing the script.

@wpferguson
Copy link
Member

If I can get an immich app instance up and running I'll start testing. I'm on 22.04 which seems to be prominently mentioned in the install docs, but not in a good way.:-)

@brainz73
Copy link
Author

I'm also on 22.04, installed with docker, started on the first try with a minimal configuration

@wpferguson
Copy link
Member

I just have to replace the ubuntu docker with the "real" docker 😄

end

du.check_min_api_version("7.0.0", "immich")

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a local title_widget line

end

if not replaced then
local album_name = title_widget.text
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line generates an error because the title_widget doesn't get defined until later. The above comment about inserting the local title_widget line fixes that.

_("A unique ID identifying this local Darktable installation"),
device_id)

local title_widget = dt.new_widget("entry") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the local since it's now defined at the top


local gettext = dt.gettext.gettext

dt.gettext.bindtextdomain("immich", dt.configuration.config_dir .."/lua/locale/")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be removed. darktable now handles string translation

@wpferguson
Copy link
Member

Tested. Got the following error

    75.4931 LUA ERROR : /home/bill/.config/darktable51/lua/contrib/immich.lua:230: attempt to index a nil value (global 'title_widget')
stack traceback:
	[C]: in metamethod 'index'
	/home/bill/.config/darktable51/lua/contrib/immich.lua:230: in function </home/bill/.config/darktable51/lua/contrib/immich.lua:208>
   135.1298 LUA ERROR : /home/bill/.config/darktable51/lua/contrib/immich.lua:230: attempt to index a nil value (global 'title_widget')
stack traceback:
	[C]: in metamethod 'index'

Added review comments that tell how to fix it.

All the images in the first album I created had a strong yellow color cast. Reset the export module and exported again and image color was correct. Not sure what that was about.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants